Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address clippy lints in tests #69

Merged
merged 2 commits into from
Oct 9, 2022
Merged

Address clippy lints in tests #69

merged 2 commits into from
Oct 9, 2022

Conversation

SanchithHegde
Copy link
Contributor

Should I also update the lint workflow to run cargo clippy --all-features --all-targets -- -D warnings instead?

@brycx
Copy link
Owner

brycx commented Oct 9, 2022 •
edited
Loading

Is that the command you used for these clippy suggestions as well? If yes, then updating the workflow would be very nice!

@SanchithHegde
Copy link
Contributor Author

Done, could you please approve the CI workflows?

brycx
brycx approved these changes Oct 9, 2022
View reviewed changes
Copy link
Owner

@brycx brycx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@brycx brycx merged commit 36fdb96 into brycx:master Oct 9, 2022
@SanchithHegde SanchithHegde deleted the tests-clippy-lints branch October 9, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycx brycx brycx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SanchithHegde @brycx