microoptimization was a bug

bryntum · Jun 18, 2020 · 54146af · 54146af
1 parent 2421d6b
commit 54146af
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/chrono2/Quark.ts b/src/chrono2/Quark.ts
@@ -204,11 +204,8 @@ export class Atom extends Owner implements Identifiable, Uniqable {
 
         const toVisit : Quark[]         = [ this.immutable ]
 
-        // avoiding `push/pop` is noticeably faster
-        let length : number = 1
-
-        while (length) {
-            const quark     = toVisit[ --length ]
+        while (toVisit.length) {
+            const quark     = toVisit.pop()
 
             const atom      = quark.owner
 
@@ -219,7 +216,7 @@ export class Atom extends Owner implements Identifiable, Uniqable {
             }
 
             quark.forEachOutgoing(outgoing => {
-                if (outgoing.owner.state === AtomState.UpToDate) toVisit[ length++ ] = outgoing
+                if (outgoing.owner.state === AtomState.UpToDate) toVisit.push(outgoing)
             })
         }