Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical paths lines stay highlighted #1043

Closed
arcady-zherdev opened this issue Jun 25, 2020 · 2 comments
Closed

Critical paths lines stay highlighted #1043

arcady-zherdev opened this issue Jun 25, 2020 · 2 comments
Assignees
Labels
bug Something isn't working bugbash regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@arcady-zherdev
Copy link

arcady-zherdev commented Jun 25, 2020

Steps to reproduce:

  1. open advanced demo
  2. click "Critical paths" button
  3. drag "Install Apache" task to start on Feb 18, 2019
  4. the task is highlighted reddish as critical
  5. click undo button (or drag the task back) to make the task non-critical
    Result: dependencies are still highlighted as critical (while tasks are no longer critical)
@arcady-zherdev arcady-zherdev added bug Something isn't working bugbash labels Jun 25, 2020
@isglass isglass added this to the Gantt 4.0.x milestone Aug 12, 2020
@fabiojpoli
Copy link

fabiojpoli commented Aug 27, 2020

@isglass I just checked that it is working on release and online, just on master is not working. But on both has this little problem that it doesnt change to red just part of the path when the record is critical:

Screen Shot 2020-08-27 at 12 39 45

I don't know if this is a bug because of this issue: #1389 but is weird

I will cover with tests this issue main problem.

@fabiojpoli fabiojpoli added regression Worked previously, now broken ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Aug 28, 2020
@fabiojpoli
Copy link

Was opened separated Issue about problem above about path partially gray: #1433

@fabiojpoli fabiojpoli added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Sep 1, 2020
@SergeyMaltsev SergeyMaltsev modified the milestones: Gantt 4.0.x, 4.0.0 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bugbash regression Worked previously, now broken resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

4 participants