Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter popup closes when field trigger is clicked #1774

Closed
bmblb opened this issue Oct 30, 2020 · 3 comments
Closed

Filter popup closes when field trigger is clicked #1774

bmblb opened this issue Oct 30, 2020 · 3 comments
Assignees
@fabiojpoli
Labels
bug Something isn't working resolved Fixed but not yet released (available in the nightly builds)
Milestone
4.0.3

Comments

@bmblb
Copy link

bmblb commented Oct 30, 2020

To reproduce on advanced demo:

  1. click filter icon on percend done column
  2. click trigger in any field
  3. popup closes
    filterpopup
@bmblb bmblb added the bug Something isn't working label Oct 30, 2020
@bmblb bmblb added this to the Gantt 4.0.1 milestone Oct 30, 2020
@matsbryntse matsbryntse modified the milestones: Gantt 4.0.1, Gantt 4.0.2 Nov 3, 2020
@fabiojpoli fabiojpoli self-assigned this Nov 3, 2020
@fabiojpoli fabiojpoli added in progress ready for review Issue is fixed, the pull request is being reviewed and removed in progress ready for review Issue is fixed, the pull request is being reviewed labels Nov 3, 2020
@fabiojpoli
Copy link

fabiojpoli commented Nov 4, 2020 •
edited
Loading

Was identified the problem with number field, flag changeOnSpin and created separated issue for it: #1811

For the current issue, was discussed with @isglass and @ExtAnimal a better UX for the number filter, when close the popup and when keep it open. Was decided to close the popup only when click out of the popup fields. Meaning, if user click on spins, press enter, or press to clean value on field ("x" icon) the popup must remain open.

Was created a test on current branch (1774) testing the correct behavior.

@bmblb
Copy link
Author

bmblb commented Nov 4, 2020

@fabiojpoli @ExtAnimal I doubt Enter press should keep filter popup open. how would you close popup with keyboard then? Esc will clear the value.

@fabiojpoli fabiojpoli added ready for review Issue is fixed, the pull request is being reviewed and removed in progress labels Nov 4, 2020
@isglass
Copy link
Contributor

isglass commented Nov 5, 2020

After trying I agree with max, should close on enter

@fabiojpoli fabiojpoli added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Nov 5, 2020
@isglass isglass modified the milestones: Gantt 4.0.2, Gantt 4.0.3 Nov 6, 2020
@SergeyMaltsev SergeyMaltsev modified the milestones: Gantt 4.0.3, 4.0.3 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabiojpoli fabiojpoli

Labels
bug Something isn't working resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Milestone
4.0.3
Development

No branches or pull requests
5 participants
@matsbryntse @fabiojpoli @isglass @bmblb @SergeyMaltsev