Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a task and drawing a dependency breaks undo/redo #6209

Closed
marciogurka opened this issue Feb 17, 2023 · 3 comments
Closed

Adding a task and drawing a dependency breaks undo/redo #6209

marciogurka opened this issue Feb 17, 2023 · 3 comments
Assignees
Labels
bug Something isn't working example forum Issues from forum high-priority Urgent to have fixed in progress info requested Further information is requested not reproducible OEM OEM customer

Comments

@marciogurka
Copy link

marciogurka commented Feb 17, 2023

Forum post

"Hello

We've found a weird bug. Creating a task in SchedulerPro, and afterwards just checking if a dependecy is valid through dragging dependency, undoing the task and redoing it, breaks the scheduler. See attached video.

Code is attached and the example used is this:
https://bryntum.com/products/schedulerpro/examples-scheduler/undoredo/

We've located the fault in the code on version 5.2.10:
File SchedulerProProjectMixin.ts on line 278 in function isDependencyCyclic:

const branch            = this.replica.branch({ autoCommit : false, onComputationCycle : 'throw' })

When this is called the redoing of an undo on create task fails. If we don't check for isDependencyCyclic then undo/redo works fine."

undo_redo_draw_dependency_bug.gif

adding_task_and_drawing_dependency_breaks_undoredo.txt

@marciogurka marciogurka added bug Something isn't working forum Issues from forum OEM OEM customer example labels Feb 17, 2023
@matsbryntse matsbryntse added the high-priority Urgent to have fixed label Feb 17, 2023
@canonic-epicure canonic-epicure self-assigned this Feb 17, 2023
@marciogurka
Copy link
Author

User added a side note here

@canonic-epicure
Copy link

Seems its not reproducible?

Screencast.2023-04-06.15.26.32.mp4

@canonic-epicure canonic-epicure added info requested Further information is requested in progress and removed in progress labels Apr 6, 2023
@canonic-epicure
Copy link

Closing this one as not reproducible. Please feel free to re-open with more detailed steps to reproduce.

@canonic-epicure canonic-epicure closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working example forum Issues from forum high-priority Urgent to have fixed in progress info requested Further information is requested not reproducible OEM OEM customer
Projects
None yet
Development

No branches or pull requests

3 participants