Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented syncOrder config for chained stores #8286

Closed
scebotari66 opened this issue Jan 17, 2024 · 1 comment
Closed

Undocumented syncOrder config for chained stores #8286

scebotari66 opened this issue Jan 17, 2024 · 1 comment
Assignees
@matsbryntse
Labels
docs Improvements or additions to documentation resolved Fixed but not yet released (available in the nightly builds)
Milestone
5.6.6

Comments

@scebotari66
Copy link

Hello! I have noticed in Core/data/mixin/StoreChained there is an undocumented syncOrder config, that will trigger refill of chained store data when master store is sorted.

Is it safe to use it? I mean is this a new undocumented config or one that will might be deprecated soon?
@matsbryntse matsbryntse self-assigned this Jan 19, 2024
@matsbryntse matsbryntse added docs Improvements or additions to documentation ready for review Issue is fixed, the pull request is being reviewed labels Jan 19, 2024
@matsbryntse
Copy link
Member

Never safe to use anything undocumented :)

We've now made this public, added test coverage and renamed flag to syncSort. Coming in the next release hopefully.

@matsbryntse matsbryntse added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Jan 19, 2024
@matsbryntse matsbryntse added this to the 5.6.6 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matsbryntse matsbryntse

Labels
docs Improvements or additions to documentation resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Milestone
5.6.6
Development

No branches or pull requests
2 participants
@matsbryntse @scebotari66