Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid cell menu with string namedItems not working #8303

Closed
JockeLindberg opened this issue Jan 19, 2024 · 0 comments
Closed

Grid cell menu with string namedItems not working #8303

JockeLindberg opened this issue Jan 19, 2024 · 0 comments
Assignees
Labels
feature request forum Issues from forum OEM OEM customer resolved Fixed but not yet released (available in the nightly builds)
Milestone

Comments

@JockeLindberg
Copy link

Fix:

  1. Add namedItems config to ContextMenuBase
  2. Add public docs

Forum post

Hello, team!

We have a grid cell menu, and we want to specify its items based on namedItems specified as a query string, to inherit the value from an ancestor widget, but it does not seem to work. It throws an error. As this works for other cases, we expect it to work in this case too.

Here is a test case with the problem:

new Panel({
	appendTo: document.body,
	title: 'Panel Title',
	height: 400,
	layout: 'fit',
	namedItems: {
		magicButton: {
			text: 'Magic Button',
		},
	},
	items: {
		grid: {
			type: 'grid',
			columns: [{ field: 'name', text: 'Name' }],
			features: {
				cellMenu: {
					namedItems: 'up.namedItems',
					items: {
						magicButton: true,
					},
				},
			},
			data: [
				{ id: 1, name: 'First' },
				{ id: 2, name: 'Second' },
				{ id: 3, name: 'Third' },
			],
		},
	},
});

@JockeLindberg JockeLindberg added feature request forum Issues from forum OEM OEM customer labels Jan 19, 2024
@JockeLindberg JockeLindberg self-assigned this Jan 19, 2024
@ExtAnimal ExtAnimal added the ready for review Issue is fixed, the pull request is being reviewed label Jan 19, 2024
@ExtAnimal ExtAnimal added this to the 5.6.6 milestone Jan 19, 2024
@isglass isglass added resolved Fixed but not yet released (available in the nightly builds) and removed ready for review Issue is fixed, the pull request is being reviewed labels Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request forum Issues from forum OEM OEM customer resolved Fixed but not yet released (available in the nightly builds)
Projects
None yet
Development

No branches or pull requests

3 participants