Convert to object-first convention for use with fast pipe #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These ignored jest assertions were never being run. Do a bit of refactoring while we're here.
zploskey
commented
Aug 15, 2018
| return (function (eta) { | ||
| return BrowserFetcher$BsPuppeteer.download("533271", undefined, eta); | ||
| })(browserFetcher[0]).then((function (info) { | ||
| return browserFetcher[0].download("533271", undefined).then((function (info) { |
There was a problem hiding this comment.
Don't try to tell me that's not an improvement in the compiled output! Now if we could just do something about that indentation.
zploskey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert all
bs.send.pipeexternals tobs.sendfor use with fast pipe (->or|.). For bindings with multiple arguments the object is moved from the last to the first argument.This is a breaking change, but one that I think is worthwhile. It eliminates a extra JS function calls in the generated JavaScript. Switching
|>to->is straight forward and the compiler will tell exactly where it needs to be changed.In a few instances it was necessary to add a final
unitargument after one or more optional arguments. Again, the compiler will complain about this and it's a straightforward fix.Fixes #36.