Convert to object-first convention for use with fast pipe

examples/logHtml.re

@@ -10,8 +10,7 @@ let logHtml = () =>
   |> then_(browser => browser |> Browser.newPage)
   |> then_(page => {
        let options = Navigation.makeOptions(~timeout=25000., ());
-       page
-       |> Page.goto("https://google.com", ~options, ())
+       page->Page.goto("https://google.com", ~options, ())
        |> then_(res => res |> Js.Null.getExn |> Response.text);
      })
   |> then_(text => Js.log(text) |> resolve)

examples/search.re

@@ -12,19 +12,18 @@ let search = () =>
        |> then_(page => {
             let options =
               Navigation.makeOptions(~timeout=20000., ~waitUntil=`load, ());
-            page
-            |> Page.goto("https://google.com", ~options, ())
-            |> then_(_ => page |> Page.type_("#lst-ib", "puppeteer", ()))
-            |> then_(() => page |> Page.click("input[type='submit']", ()))
-            |> then_(() => page |> Page.waitForSelector("h3 a", ()))
+            page->Page.goto("https://google.com", ~options, ())
+            |> then_(_ => page->Page.type_("#lst-ib", "puppeteer", ()))
+            |> then_(() => page->Page.click("input[type='submit']", ()))
+            |> then_(() => page->Page.waitForSelector("h3 a", ()))
             |> then_(() =>
                  page
-                 |> Page.selectOneEval(
-                      "h3 a",
-                      [%raw
-                        {| function (element) { return element.textContent; } |}
-                      ],
-                    )
+                 ->Page.selectOneEval(
+                     "h3 a",
+                     [%raw
+                       {| function (element) { return element.textContent; } |}
+                     ],
+                   )
                )
             |> then_(text => Js.log2("Got:", text) |> resolve)
             |> then_(_ => Browser.close(browser))

examples/takeScreenshot.re

@@ -8,13 +8,12 @@ let takeScreenshot = () =>
        browser
        |> Browser.newPage
        |> then_(page =>
-            page
-            |> Page.goto("https://google.com", ())
+            page->Page.goto("https://google.com", ())
             |> then_(_ => {
                  Js.log("screenshotting");
                  let options =
                    Screenshot.makeOptions(~path="./screenshot.png", ());
-                 page |> Page.screenshot(~options, ());
+                 page->Page.screenshot(~options, ());
                })
           )
        |> then_(_ => Browser.close(browser))

package.json

@@ -19,7 +19,7 @@
     "build": "bsb -make-world",
     "clean": "bsb -clean-world",
     "lint-staged": "lint-staged",
-    "precommit": "lint-staged",
+    "precommit": "bsb -make-world && lint-staged",
     "start": "bsb -make-world -w",
     "test": "bsb -make-world && jest",
     "test:ci": "jest --bail --ci",

src/BrowserFetcher.re

@@ -15,14 +15,10 @@ external empty: unit => t = "%identity";
 
 [@bs.send]
 external download:
-  (t, string, Js.Undefined.t((float, float) => unit)) =>
+  (t, ~revision: string, ~progressCallback: (float, float) => unit=?, unit) =>
   Js.Promise.t(revisionInfo) =
   "";
 
-let download =
-    (~revision, ~progressCallback=?, t): Js.Promise.t(revisionInfo) =>
-  download(t, revision, progressCallback |> Js.Undefined.fromOption);
-
 [@bs.send] external localRevisions: t => Js.Promise.t(array(string)) = "";
 
 [@bs.deriving jsConverter]

src/CDPSession.re

@@ -4,8 +4,5 @@ type t;
 
 [@bs.send]
 external send:
-  (t, string, Js.Undefined.t(Js.t({..}))) => Js.Promise.t(Js.t({..})) =
+  (t, string, ~params: Js.t({..})=?, unit) => Js.Promise.t(Js.t({..})) =
   "";
-
-let send = (~method_, ~params=?, t) =>
-  send(t, method_, params |> Js.Undefined.fromOption);

src/Coverage.re

@@ -34,18 +34,14 @@ external makeJSCoverageOptions:
 
 [@bs.send]
 external startCSSCoverage:
-  (t, ~options: cssCoverageOptions=?) => Js.Promise.t(unit) =
+  (t, ~options: cssCoverageOptions=?, unit) => Js.Promise.t(unit) =
   "";
 
-let startCSSCoverage = (~options=?, t) => startCSSCoverage(t, ~options?);
-
 [@bs.send]
 external startJSCoverage:
-  (t, ~options: jsCoverageOptions=?) => Js.Promise.t(unit) =
+  (t, ~options: jsCoverageOptions=?, unit) => Js.Promise.t(unit) =
   "";
 
-let startJSCoverage = (~options=?, t) => startJSCoverage(t, ~options?);
-
 [@bs.send] external stopCSSCoverage: t => Js.Promise.t(array(report)) = "";
 
 [@bs.send] external stopJSCoverage: t => Js.Promise.t(array(report)) = "";

src/ElementHandle.re

@@ -19,8 +19,9 @@ let boxModel = handle =>
   boxModel(handle)
   |> Js.Promise.(then_(handle => Js.toOption(handle) |> resolve));
 
-[@bs.send.pipe: t]
-external click: (~options: Click.clickOptions=?, unit) => Js.Promise.t(unit) =
+[@bs.send]
+external click:
+  (t, ~options: Click.clickOptions=?, unit) => Js.Promise.t(unit) =
   "";
 
 [@bs.send] external focus: t => Js.Promise.t(unit) = "";
@@ -29,36 +30,39 @@ external click: (~options: Click.clickOptions=?, unit) => Js.Promise.t(unit) =
 
 [@bs.send] external isIntersectingViewport: t => Js.Promise.t(bool) = "";
 
-[@bs.send.pipe: t]
+[@bs.send]
 external press:
-  (~key: string, ~options: Keyboard.options=?, unit) => Js.Promise.t(unit) =
+  (t, ~key: string, ~options: Keyboard.options=?, unit) => Js.Promise.t(unit) =
   "";
 
-[@bs.send.pipe: t]
+[@bs.send]
 external screenshot:
-  (~options: Screenshot.options=?, unit) => Js.Promise.t(Node.Buffer.t) =
+  (t, ~options: Screenshot.options=?, unit) => Js.Promise.t(Node.Buffer.t) =
   "";
 
-[@bs.send.pipe: t]
-external selectOne: (~selector: string) => Js.Promise.t(Js.Null.t(t)) = "$";
+[@bs.send]
+external selectOne: (t, ~selector: string) => Js.Promise.t(Js.Null.t(t)) =
+  "$";
 
-[@bs.send.pipe: t]
-external selectAll: (~selector: string) => Js.Promise.t(array(t)) = "$$";
+[@bs.send]
+external selectAll: (t, ~selector: string) => Js.Promise.t(array(t)) = "$$";
 
-[@bs.send.pipe: t]
-external selectXPath: (~xpath: string) => Js.Promise.t(array(t)) = "$x";
+[@bs.send]
+external selectXPath: (t, ~xpath: string) => Js.Promise.t(array(t)) = "$x";
 
 [@bs.send] external tap: t => Js.Promise.t(unit) = "";
 
 [@bs.send] external toString: t => string = "";
 
-[@bs.send.pipe: t]
+[@bs.send]
 external type_:
-  (~text: string, ~options: {. "delay": float}=?, unit) => Js.Promise.t(unit) =
+  (t, ~text: string, ~options: {. "delay": float}=?, unit) =>
+  Js.Promise.t(unit) =
   "type";
 
-[@bs.send.pipe: t] [@bs.splice]
-external uploadFile: (~filePaths: array(string)) => Js.Promise.t(unit) = "";
+[@bs.send] [@bs.splice]
+external uploadFile: (t, ~filePaths: array(string)) => Js.Promise.t(unit) =
+  "";
 
 [@bs.send]
 external contentFrame: t => Js.Promise.t(Js.Null.t(Types.frameBase)) = "";