Fix typescript circular ref errors and typing improvements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function return type typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the circular ref typescript errors with newer typescript as mentioned in #1 and upgrades typescript to 3.6.4
Also
Improves array typing so it knows if something is not an array then array indexes are invalid (this went hand and hand with typescript circular errors fix so I just did it)
Function return types so
a.myfunc.resultworks nowRemoves checked in built files
'path' is a rather common field name so I changed it to be $path to avoid conflicts and its just a proxied field now instead of a function call for convenience
Sorry for dragging this PR into more than just the typescript errors fix can break it up into multiple PRs if you really really want it to be like that.