Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests of search logic #26

Closed
bsamseth opened this issue Feb 8, 2019 · 1 comment
Closed

Add tests of search logic #26

bsamseth opened this issue Feb 8, 2019 · 1 comment
Labels
enhancement
Milestone
v1.9.0

Comments

@bsamseth
Copy link
Owner

bsamseth commented Feb 8, 2019

At the moment, the entire search logic is outside the test suite. This is no good and has possibly allowed the bugs seen in #25 to sneak in.

The current idea is to have some tests written in Python, using python-chess to communicate with Goldfish and add assertions to the parsed output for some selected positions.

Most importantly, it should be verified that search correctly identifies short mating sequences, and does not behave as in #25.
@ddugovic ddugovic mentioned this issue Feb 8, 2019
Closed
@bsamseth bsamseth mentioned this issue Feb 10, 2019
Merged
@bsamseth bsamseth added this to the v1.9.0 milestone Feb 14, 2019
bsamseth added a commit that referenced this issue Feb 15, 2019
@bsamseth
Merge pull request #27 from bsamseth/search-refactor
112802e 
Search Refactor & Verification

Fixes #25 and #26.

```
    Goldfish v1.9.0 2353.1 :    430 (+201,=159,-70),  65.2 %

    vs.                    :  games (   +,   =,  -),   (%) :    Diff
    Goldfish v1.7.0        :    215 ( 101,  84, 30),  66.5 :  +101.6
    Goldfish v1.8.2        :    215 ( 100,  75, 40),  64.0 :  +119.1

   # PLAYER             :  RATING  POINTS  PLAYED   (%)
   1 Goldfish v1.9.0    :  2353.1   280.5     430    65
   2 Goldfish v1.7.0    :  2251.5   877.5    1699    52
   3 Goldfish v1.7.1    :  2243.8   244.0     477    51
   4 Goldfish v1.8.0    :  2237.0   324.0     650    50
   5 Goldfish v1.8.1    :  2234.1   485.5    1000    49
   6 Goldfish v1.8.2    :  2234.0   174.0     429    41
   7 Goldfish v1.6.0    :  2218.7   434.5     797    55
   8 Goldfish v1.7.2    :  2218.0    69.5     150    46
   9 Goldfish v1.5.1    :  2168.8   460.5     970    47
  10 Goldfish v1.5      :  2158.6   554.5    1145    48
  11 Goldfish v1.4      :  2153.5   487.0     970    50
  12 Goldfish v1.3      :  2130.7   162.5     325    50
  13 Goldfish v1.2      :  2112.2   107.5     230    47
  14 Goldfish v1.1      :  2055.2    93.0     232    40
  15 Goldfish v1.0      :  2000.0    13.5      32    42
```
@bsamseth
Copy link
Owner Author

Closed by #27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.9.0
Development

No branches or pull requests
1 participant
@bsamseth