Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from ES5 to ES6 #11

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Move from ES5 to ES6 #11

merged 1 commit into from
Mar 9, 2017

Conversation

bsander
Copy link
Owner

@bsander bsander commented Mar 8, 2017

What has been done

  • Changed eslint config to prefer ES6
  • Ran eslint --fix .

How to test

  • CI should do the trick


var dJSON = require('djson');
const dJSON = require('djson');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it: can this dependency be removed?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it could, but that would kind of break everything.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, its exported...

@edwardsmit edwardsmit merged commit 25ac1c0 into master Mar 9, 2017
@bsander bsander deleted the feature/es5-to-6 branch April 6, 2017 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants