Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CIDR functions (cidr, cidrv4 and cidrv6) #36

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

yoo
Copy link
Contributor

@yoo yoo commented Apr 22, 2024

This PR adds asserts for CIDR functions. I basically copied the IP function code and adopted it to CIDR parsing.

@bschaatsbergen
Copy link
Owner

Hey @yoo, this looks awesome. Thanks for taking the time to create this pull request. Allow me to review it tomorrow 👍🏼🖤

Copy link
Owner

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bschaatsbergen bschaatsbergen merged commit 987861b into bschaatsbergen:main Apr 23, 2024
3 checks passed
@bschaatsbergen
Copy link
Owner

bschaatsbergen commented Apr 23, 2024

Thanks for your contributions @yoo 👏🏼 ! I'll release these under v0.6.0

@bschaatsbergen bschaatsbergen added this to the v0.6.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants