Skip to content

Commit

Permalink
fix: The FavroApi typings import paths are being exported incorrectly…
Browse files Browse the repository at this point in the history
…, breaking types in the build.
  • Loading branch information
adam-coster committed Aug 29, 2021
1 parent 62be70d commit 4cb3734
Show file tree
Hide file tree
Showing 10 changed files with 9 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/lib/BravoClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { readFileSync } from 'fs';
import { basename } from 'path';
import { BravoTagDefinition } from './entities/BravoTag.js';
import type { BravoEntity } from './BravoEntity.js';
import type { FavroApi } from '$favro';
import type { FavroApi } from '$types/FavroApi.js';

type ConstructorFavroEntity<EntityData extends Record<string, any>> = new (
client: BravoClient,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/clientLib/BravoResponse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { BravoEntity } from '$lib/BravoEntity';
import type { FavroResponse } from './FavroResponse';
import type { BravoWidget } from '$entities/BravoWidget.js';
import type { BravoCustomFieldDefinition } from '../entities/BravoCustomField.js';
import type { FavroApi } from '$favro';
import type { FavroApi } from '$types/FavroApi.js';
import type { BravoTagDefinition } from '../entities/BravoTag.js';

export type BravoResponseWidgets = BravoResponseEntities<
Expand Down
2 changes: 1 addition & 1 deletion src/lib/clientLib/FavroResponse.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Response } from 'node-fetch';
import { URL } from 'url';
import type { FavroApi } from '$favro';
import type { FavroApi } from '$types/FavroApi.js';
import { BravoError } from '../errors.js';
import type { FavroClient } from './FavroClient.js';

Expand Down
2 changes: 1 addition & 1 deletion src/lib/entities/BravoCollection.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { BravoEntity } from '../BravoEntity.js';
import type { BravoWidget } from './BravoWidget.js';
import type { FavroApi } from '$favro';
import type { FavroApi } from '$types/FavroApi.js';

export class BravoCollection extends BravoEntity<FavroApi.Collection.Model> {
get name() {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/entities/BravoColumn.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { BravoEntity } from '$lib/BravoEntity.js';
import type { FavroApi } from '$favro';
import type { FavroApi } from '$types/FavroApi.js';

/**
* A Favro Column is one of the available values for the default
Expand Down
2 changes: 1 addition & 1 deletion src/lib/entities/BravoCustomField.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { BravoEntity } from '$lib/BravoEntity.js';
import { assertBravoClaim, BravoError } from '../errors.js';
import type { FavroApi } from '$favro';
import type { FavroApi } from '$types/FavroApi.js';

type DataFavroCustomFieldTypeWithChoices = Extract<
FavroApi.CustomFieldType,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/entities/BravoTag.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { BravoEntity } from '$lib/BravoEntity.js';
import type { FavroApi } from '$favro';
import type { FavroApi } from '$types/FavroApi.js';

/** Hydrated Favro Organization. */
export class BravoTagDefinition extends BravoEntity<FavroApi.Tag.Model> {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/entities/BravoWidget.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { BravoEntity } from '$lib/BravoEntity.js';
import { stringsMatch } from '$lib/utility.js';
import type { FavroApi } from '$favro';
import type { FavroApi } from '$types/FavroApi.js';
import type { BravoColumn } from './BravoColumn.js';
import type { ArrayMatchFunction } from '$/types/Utility.js';
import type { BravoCardInstance } from './BravoCard.js';
Expand Down
2 changes: 1 addition & 1 deletion src/test/client.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import {
import { assertBravoClaim } from '$/lib/errors.js';
import type { BravoUser } from '$/lib/entities/BravoUser.js';
import type { BravoTagDefinition } from '$/lib/entities/BravoTag.js';
import type { FavroApi } from '$favro';
import type { FavroApi } from '$types/FavroApi.js';

/**
* @remarks A root .env file must be populated with the required
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"$lib/*": ["src/lib/*"],
"$entities/*": ["src/lib/entities/*"],
"$types/*": ["src/types/*"],
"$favro": ["src/types/FavroApi.js"],
"$cli/*": ["src/cli/*"],
"$test/*": ["src/test/*"]
}
Expand Down

0 comments on commit 4cb3734

Please sign in to comment.