feat: Change the find-collection-by-id method to directly hit the sin…

…gle-collection API endpoint if not found in cache.

src/lib/BravoClient.ts

@@ -10,7 +10,7 @@ import {
   FavroDataCollection,
 } from '../types/FavroApi';
 import { FavroResponse } from './FavroResponse';
-import { findRequiredByField } from './utility.js';
+import { findByField, findRequiredByField } from './utility.js';
 import { FavroCollection } from './FavroCollection';
 import { FavroUser } from './FavroUser';
 
@@ -282,12 +282,24 @@ export class BravoClient {
   }
 
   async findCollectionById(collectionId: string) {
-    return findRequiredByField(
-      await this.listCollections(),
+    // See if already in the cache
+    let collection = findByField(
+      this._collections || [],
       'collectionId',
       collectionId,
-      { ignoreCase: true },
     );
+    if (!collection) {
+      // Then hit the API directly!
+      const res = await this.request<FavroDataCollection>(
+        `collections/${collectionId}`,
+      );
+      assertBravoClaim(
+        res.entities.length == 1,
+        `No collection found with id ${collectionId}`,
+      );
+      collection = new FavroCollection(res.entities[0]);
+    }
+    return collection;
   }
 
   //#endregion

src/lib/utility.ts

@@ -9,15 +9,15 @@ export function stringsMatchIgnoringCase(string1: string, string2: string) {
   );
 }
 
-export function findRequiredByField<
+export function findByField<
   Item extends Record<string, any>,
   Field extends keyof Item,
 >(
   findIn: Item[],
   byField: Field,
   value: Item[Field],
   options?: { ignoreCase?: boolean },
-): Item {
+): Item | undefined {
   assertBravoClaim(findIn, 'Search array does not exist');
   const item = findIn.find((item) => {
     if (
@@ -29,6 +29,19 @@ export function findRequiredByField<
     }
     return item[byField] == value;
   });
+  return item;
+}
+
+export function findRequiredByField<
+  Item extends Record<string, any>,
+  Field extends keyof Item,
+>(
+  findIn: Item[],
+  byField: Field,
+  value: Item[Field],
+  options?: { ignoreCase?: boolean },
+): Item {
+  const item = findByField(findIn, byField, value, options);
   assertBravoClaim(item, 'Matching entity not found');
   return item;
 }