feat: Change the listGroups method to return an already-fully-listed …

…array, since there aren't likely to be a ton of groups in an org.
bscotch · Sep 27, 2021 · 959c110 · 959c110
1 parent b97342f
commit 959c110
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bscotch/bravo",
-  "description": "Bravo is a Favro SDK by Butterscotch Shenanigans",
+  "description": "Bravo: A Favro SDK with full Typescript support and tons of convenience features. By Butterscotch Shenanigans",
   "repository": "https://github.com/bscotch/favro-sdk",
   "homepage": "https://github.com/bscotch/favro-sdk#readme",
   "author": "Adam Coster",

diff --git a/src/lib/BravoClient.ts b/src/lib/BravoClient.ts
@@ -824,7 +824,7 @@ export class BravoClient extends FavroClient {
       { method: 'get' },
       BravoGroup,
     )) as BravoResponseEntities<FavroApi.Group.Model, BravoGroup>;
-    return res;
+    return await res.getAllEntities();
   }
 
   async findGroupById(groupId: string) {
@@ -833,7 +833,7 @@ export class BravoClient extends FavroClient {
       { method: 'get' },
       BravoGroup,
     )) as BravoResponseEntities<FavroApi.Group.Model, BravoGroup>;
-    return res.getFirstEntity();
+    return await res.getFirstEntity();
   }
 
   //#endregion