Allow specifying pf_rules file to patch on init #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When altering more complex setups automatically, pot's way of patching pf.conf is a bit too simplistic. By adding this flag, the user has multiple choices of modifying pf.conf in a controlled way: 1. Write to a different file that's included in pf.conf using its include keyword. 2. Write to a different file that's parsed by additional tooling to assemble a pf.conf (e.g., in automation). 3. In setups where pots modifications serve no real purpose, running `pot init -f ''` can be used to skip touching pf.conf completely. Help text intentionally shows the default to be determined by a command, not the result of it. This is the first patch of a series, with more complex ones to follow, which serve the ultimate purpose of making pot's networking more flexible/customizable using hooks, so it can be integrated into different network environments (as one size doesn't fit all).
grembo
force-pushed
the
init-pf-file-location
branch
from
95edf32
to
42f28de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When altering more complex setups automatically, pot's
way of patching pf.conf is a bit too simplistic.
By adding this flag, the user has multiple choices of modifying
pf.conf in a controlled way:
using its include keyword.
tooling to assemble a pf.conf (e.g., in automation).
running
pot init -f ''can be used to skip touchingpf.conf completely.
Help text intentionally shows the default to be determined
by a command, not the result of it.
This is the first patch of a series, with more complex ones
to follow, which serve the ultimate purpose of making pot's
networking more flexible/customizable using hooks, so it
can be integrated into different network environments (as
one size doesn't fit all).