The current sed script delete everything

[pizzamig]

This easy fix, while not super robust, seems a first good patch

fix #224

[grembo]

strange, I'll take a look as well

[grembo]

Oh my - it only deletes the first appearance. Unfortunately, the first time status is written, there is only one appearance.
The easiest fix would be to always write the status twice.

[pizzamig]

If you agree, I'll do an emergency release for conference reasons.
A more robust patch can come later

[grembo]

Suggested change

	${SED} -i '' -e '1d' "$_status_file"
	${SED} -i '' -n -e ":a" \
	-e '/^pot\.status=/{n;bc' -e ':c' -e 'p;n;bc' -e '}' \
	-e "p;n;ba" "$_status_file"'

This (combined with your new check) should work fine. It always removes the first status line (but it doesn't figure out that there is only one, which is what your grep fixes now). >_<

[grembo]

If you agree, I'll do an emergency release for conference reasons. A more robust patch can come later

I can test the proposed patch right away, should work just fine, but I can confirm in a few minutes.

[pizzamig]

Just updated the patch to call sed only if there are multiple entries

[grembo]

So the patch seems to work. But there are more problems. I'll elaborate in a second.

[pizzamig]

Technically, we can rework it to overwrite the entire file with the last entry available (like get_status)

[grembo]

# pot start cloneme
###>  No ipv4 address found for cloneme
###>  pot cloneme is not in a state where it can be stopped
# pot show
# cat /tmp/pot_status_cloneme
pot.status=starting
# pot set-status -p cloneme -s stopping || echo "PROBLEM"
PROBLEM
# pot set-status -p cloneme -s started || echo "PROBLEM"
# pot set-status -p cloneme -s stopping || echo "PROBLEM"
# pot set-status -p cloneme -s stopped || echo "PROBLEM"

So basically, problems during start keep the pot stuck in "starting", since it can't go from "starting" directly to "stopping". Updated

[grembo]

Technically, we can rework it to overwrite the entire file with the last entry available (like get_status)

No, the patch is fine and solves the issue at hand. We have an unrelated problem in the logic (see details above).
IMHO this patch can land now and we can resolve the other issue in a separate PR.

[grembo]

This fixes the problem described, but a separate issue persists.

[pizzamig]

I see your point

[grembo]

So basically "start-cleanup" calls "pot stop" and if the pot hasn't started yet, it can't stop (stopping->stopped).

[grembo]

I think the cleanest solution would be a new status like "doa" and allow to go from "doa" to stopping as well (just like from started).
Then start-cleanup could set "doa" (ignoring a potential error if the pot was already started and could not go to doa). Should I prepare a patch?

[grembo]

Patch incoming...