Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup improvements #4

Closed
wants to merge 1 commit into from
Closed

Setup improvements #4

wants to merge 1 commit into from

Conversation

till
Copy link

@till till commented Dec 20, 2012

We've been trying to get this code running and here are a few improvements up front.

We are also in the process of trying to figure out why the final request to /grant times out - no luck yet and probably also a PR for bshaffer/oauth2-server-php.


Changelog

Switch to dev-master (since dev-develop contains bugs).

rebuild_db.php

  • move rebuild_db.php to a bin directory and adjust the path to the database
  • make it executable and add a shebang

Fixes by @dazz:

  • Add missing table to rebuild_db.php script.
  • Add some sample data (note: the code requires to run on port 80 - somewhere.)

The piece about port 80 may or may not be a bug. It took me a while to debug this with the custom curl code in there and it just said that it timed out while trying to request something on localhost:80 and I had the code running on localhost:8002 (through PHP's internal web server).

rebuild_db.php

 * move rebuild_db.php to a bin directory and adjust the path to the database
 * make it executable and add a shebang

Fixes by @dazz:

 * Add missing table to rebuild_db.php script.
 * Add some sample data (note: the code requires to run on port 80 - somewhere.)
@bshaffer
Copy link
Owner

I was unaware of bugs in the oauth2-server-php/develop branch. Could you expand on that?

@till
Copy link
Author

till commented Dec 21, 2012

@bshaffer The develop branch didn't work at all due to some I think bugfixes or changes which had not been merged into it. One of my devs emailed with you yesterday or day before yesterday.

There seem to be more tables missing in the demo app, we'll add to this PR later.

@bshaffer
Copy link
Owner

There shouldn't be any changes in master that don't exist in develop... only the other way around. Thanks for reporting this though, I will look into it.

@bshaffer
Copy link
Owner

Thank you for your help!
I couldn't duplicate yur issue. At the time of this pull request, switching to master would break the server calls because the class interfaces changed. Is it possible your code was not up to date?

Still, I think switching to the master branch (and more specifically to a tag in th master branch) is wise.

Also, this PR breaks the call to create_db in the frontend controller: https://github.com/bshaffer/oauth2-server-demo/blob/master/web/index.php

Please resubmit with this fix and I'll merge. Thanks again!

@bshaffer bshaffer closed this Dec 24, 2012
@itsazzad itsazzad mentioned this pull request Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants