fix got null some time

[WitzHsiao]

I found a bug when I get Access Token from DynamoDB, which will got null very some time.

[bshaffer]

I feel like the ConsistentRead option could be supplied to the DynamoDB storage on creation. This would allow the user of the application to decide if they wanted to use consistent reads or not.

Eventual Consistency most likely would be acceptable in most cases.

[WitzHsiao]

sounds like a plan!

[bshaffer]

is this something you are willing to add in another Pull Request?

[bshaffer]

@WitzHsiao are you planning on submitting a PR for this change?

[WitzHsiao]

@bshaffer Sorry for reply lately. I've changed it to get ConsistenRead from config of DynamoDB.

[bshaffer]

These should all read

"ConsistentRead" => $this->config['consistent_read'] 

With the consistent_read parameter being defined here and defaulting to false

[bshaffer]

Also, there's a typo. All of these say ConsistenRead instead of ConsistentRead.

Also, we need tests.

[bshaffer]

@WitzHsiao pinging on this open issue

[WitzHsiao]

@bshaffer Sorry, forgot this issue. Thanks for review. I have already fix the typo in the second commit.

[bshaffer]

This is not what I had in mind. Rather than using isset each time, you can have the parameter defaulted in the constructor. i.e here:

        $this->config = array_merge(array(
            'client_table' => 'oauth_clients',
            'access_token_table' => 'oauth_access_tokens',
            'refresh_token_table' => 'oauth_refresh_tokens',
            'code_table' => 'oauth_authorization_codes',
            'user_table' => 'oauth_users',
            'jwt_table'  => 'oauth_jwt',
            'scope_table'  => 'oauth_scopes',
            'public_key_table'  => 'oauth_public_keys',
            'consistent_read' => false, // <---- HERE
        ), $config);