Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate matching differences in optional-line head vs tail when optional line not present #90

Open
bskinn opened this issue Oct 16, 2019 · 0 comments
Open

Investigate matching differences in optional-line head vs tail when optional line not present #90

bskinn opened this issue Oct 16, 2019 · 0 comments
Labels
investigate maybe
Milestone
Later

Comments

@bskinn
Copy link
Owner

bskinn commented Oct 16, 2019 •
edited

Compare the passing test cases here for head, and here for tail.

Presumably it has something to do with the regex having to match head in order to get to body, whereas it can discard/ignore tail once it's grabbed body?

Unclear why this would lead to the None matching output, though. Seems like the head pattern has to be making a pair of length-zero matches immediately before the body content starts.

This seems like a really uncommon situation, though...and it's not like it makes the Parser fail to match. So, figuring it out seems really YAGNI.
@bskinn bskinn added this to the Later milestone Oct 16, 2019
bskinn added a commit that referenced this issue Oct 16, 2019
@bskinn
Add optional-line tail tests
2f41d48 
Closes #52.

New #90 is still outstanding as of this point; though, it's
almost certainly YAGNI, and thus of very low priority.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigate maybe
Projects
None yet
Milestone
Later
Development

No branches or pull requests
1 participant
@bskinn