Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention priority 0 and 2 #284

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Mention priority 0 and 2 #284

merged 2 commits into from
Aug 31, 2023

Conversation

pawamoy
Copy link
Sponsor Contributor

@pawamoy pawamoy commented Aug 28, 2023

Is the PR a fix or a feature?
Docs change.

Describe the changes in the PR
I simply add a mention of what Sphinx expects for priorities other than 1 and -1.
Just reading the current docs led to me think 0 would be low priority, and then 2, 3, 4, etc. higher priorities.
I'm not sure if priorities higher than 2 make sense to Sphinx 馃槙

Does this PR close any issues?
No.

Does the PR change/update the following, if relevant?

  • Documentation
  • Tests
  • CHANGELOG

doc/source/syntax.rst Outdated Show resolved Hide resolved
@bskinn
Copy link
Owner

bskinn commented Aug 30, 2023

Thanks for this, @pawamoy!

One thing -- the PR is opened against stable as base branch, when it needs to be against main. Can you rebase?

I'll look into the linkcheck failure...

@bskinn
Copy link
Owner

bskinn commented Aug 30, 2023

Looks like the Arch Linux reference in index.rst needs to be updated to https://archlinux.org/packages/extra/any/python-sphobjinv/

Could you fix that in this PR?

@pawamoy
Copy link
Sponsor Contributor Author

pawamoy commented Aug 31, 2023

Sure, done 馃檪

@bskinn bskinn changed the base branch from stable to main August 31, 2023 14:21
@bskinn
Copy link
Owner

bskinn commented Aug 31, 2023

All good now, thanks @pawamoy!

@bskinn bskinn merged commit df27855 into bskinn:main Aug 31, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants