CI: Try simple pypy3 template job add #82
Conversation
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 101 101
=====================================
Hits 101 101Continue to review full report at Codecov.
|
|
@jayvdb pypy3 was easy to add. I had to relax slightly a few error message checks -- apparently pypy3 does something different with periods on the ends of error messages?? I only added a linux pypy3 job -- are the platform differences substantial enough that I should add win/mac too? |
Win yes; Mac, no. Replied longer at #81 (comment) |
- pypy3 doesn't append a period to its error messages? And/or, it actively strips them?? - The warnings_are_errors fixture was returning None when '-W' was not supplied, and pytest doesn't like it when you do a bare 'assert None'. So, explicit bool conversion added - Improve skip message for tests using warnings when '-W error::Warning' is passed - Add Windows pypy3 job, per #82 (comment)
There was a problem hiding this comment.
If the difference is only "I/O operation on closed file" vs "I/O operation on closed file." , it would be nice to have them as two constants at the top, and use in instead of ==
#78 is already needing a constant for the msg "underlying buffer has been detached"
Ennnnnhhh, Azure's Windows pypy3 appears broken. :-/ |
|
Oh, hm.... looks like a pytest problem... |
|
You might also try disabling pytest's use of faulthandler. https://github.com/vstinner/faulthandler (backport to py27, and py26 was working) says
That repo would also be a good spot to identify issues. We might be able to get that backport to override the PyPy native one if it is broken. |
|
But that's regular pypy (Python 2) .. does that also apply to pypy3? |
Also increase quality of naming on the extra-cmd steps.
|
pytest downgrade successful. |
Might as well keep that mess separate....
- Eliminate "underlying buffer has been detached" magic string
- Use 'assert x in {set}' construction for accommodating the
extra period pypy3 adds in (per
#82 (review)
- Eliminate "underlying buffer has been detached" magic string
- Use 'assert x in {set}' construction for accommodating the
extra period pypy3 adds in (per
#82 (review)
Recommit to re-trigger CI.
|
Ok, @jayvdb, I think it's ready. |
Part of #81