Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisClient error #49

Closed
mertcakmak2 opened this issue Oct 6, 2022 · 8 comments
Closed

RedisClient error #49

mertcakmak2 opened this issue Oct 6, 2022 · 8 comments

Comments

@mertcakmak2
Copy link

I try your example code but doesn't working.

Go version: go1.19.1 windows/amd64
redislock version in go mod file: github.com/bsm/redislock v0.8.0
redis version in go mod file: github.com/go-redis/redis/v9 v9.0.0-beta.3

I have error as below.

redislock.go:149:31: cannot use l.client.client (variable of type RedisClient) as type redis.Scripter in argument to
luaPTTL.Run:
RedisClient does not implement redis.Scripter (missing EvalRO method)
C:\Users\P1608\go\pkg\mod\github.com\bsm\redislock@v0.8.0\redislock.go:166:37: cannot use l.client.client (variable of type RedisClient) as type redis.Scripter in argument to
luaRefresh.Run:
RedisClient does not implement redis.Scripter (missing EvalRO method)
C:\Users\P1608\go\pkg\mod\github.com\bsm\redislock@v0.8.0\redislock.go:178:34: cannot use l.client.client (variable of type RedisClient) as type redis.Scripter in argument to
luaRelease.Run:
RedisClient does not implement redis.Scripter (missing EvalRO method)

@dim
Copy link
Member

dim commented Oct 7, 2022

Duplicate of #46

@dim dim marked this as a duplicate of #46 Oct 7, 2022
@dim dim closed this as completed Oct 7, 2022
@dim dim reopened this Oct 7, 2022
@dim
Copy link
Member

dim commented Oct 7, 2022

Apologies, I see it now, fixed in #50

@dim
Copy link
Member

dim commented Oct 7, 2022

Pushed new release, thanks for reporting the issue

@dim dim closed this as completed Oct 7, 2022
@nmfzone
Copy link

nmfzone commented Dec 10, 2022

And now redislock drop support for go redis v8?

@dim
Copy link
Member

dim commented Dec 12, 2022

@nmfzone the v8 branch of https://github.com/go-redis/redis is not being maintained by its author either but you can always pin your go.mod to 0.7.x version of this lib?

@nmfzone
Copy link

nmfzone commented Dec 12, 2022

Yeah, I know. Well, if you can keep support for redis v8 then it's good, right? Since there is a lot users who still using v8, especially in production. #justmy2cent

@dim
Copy link
Member

dim commented Dec 12, 2022

Sure, we can backport new features and release them as 0.7.x tags. Is there anything you are missing right now?

@dim
Copy link
Member

dim commented Dec 12, 2022

Here you go, here's a new branch https://github.com/bsm/redislock/tree/0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants