Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

ConsumerRebalanceListener alternative #18

Closed
daft-panda opened this issue Jan 6, 2016 · 1 comment
Closed

ConsumerRebalanceListener alternative #18

daft-panda opened this issue Jan 6, 2016 · 1 comment

Comments

@daft-panda
Copy link

Similar to the ConsumerRebalanceListener of the Java API, it would be great to get informed by the consumer that the partition assignments have changed so related state can be updated or logged.

On first glance, adding a channel to the API where rebalance events are posted and selected in the same loop as Messages seems like a good idea.
Removals would get posted before https://github.com/bsm/sarama-cluster/blob/master/consumer.go#L267, whereas additions would get posted after the partition consumer was succesfully created, following the specifications outlined in the Java doc.

@dim
Copy link
Member

dim commented Feb 11, 2016

Superseded by #21

@dim dim closed this as completed Feb 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants