Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "2 Click Install" feature #232

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add "2 Click Install" feature #232

wants to merge 7 commits into from

Conversation

idolize
Copy link

@idolize idolize commented Sep 7, 2020

Background

Optional feature support for installing custom maps that do not contain any audio file.

This is part of a series of changes aimed at allowing custom maps to be created, uploaded, and used all without distributing any song file directly (instead the user must supply their own song).

See this post for more background: https://medium.com/@idolize/beat-saber-the-future-of-custom-songs-d64756818be7

Change

Upon detecting there is no included audio in the download (but there is audio.json and fingerprint.bin):

  1. Prompts user to select a master audio file to use with the map
  2. Utilizes SaberSongPatcher NuGet package published from https://github.com/idolize/saber-song-patcher to verify the song works with the map
  3. Patches the song with any tweaks
  4. Renames and re-encodes the song to whatever file name is listed in Info.dat

Tested locally using custom BeatSaver instance.

The change increases the size of the overall size of the build pretty significantly - this is 99% due to the inclusion of ffmpeg binaries. I can look into some ways of optimizing this (e.g. only include x86 OR x64 ffmpeg binaries from the NuGet package, download ffmpeg at runtime, only include used ffmpeg features, etc.), but for now am just leaving it all as a proof of concept.

Related

luludotdev/beatsaver-reloaded#85
luludotdev/beatmap-schemas#10

@Chief-Wompaho
Copy link

A novice here in the best sense but wouldn’t a viable idea for such a magnificent VR game be to downgrade some of the resolution quality and sample size?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants