New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect multiplication behavior on last cycle prior to next multiplication/division #256
Comments
Unfortunatly, this project is pretty much dead. But thank you for the report. Maybe ares can do something with that info. |
I will take a look tonight and see if I can come up with a working solution. |
Sure! Then this fix can be ported to the other two forks (particularly ares, since that's still actively maintained to my knowledge). |
Here is a draft solution against the master branch of this repo which could probably be cleaned up a bit, but it appears to have correct behaviour. If anyone would like to test this to make sure it does not introduce regressions, that would be wonderful. I also have a solution for bsnes-jg which is posted on the nesdev forum (pending approval).
|
For reference here is the fix for the jgemu bsnes fork. https://gitlab.com/jgemu/bsnes/-/commit/ff43a0d611ae99e306af6050a9de062fcf7bc043 |
Forwarded from the NESDev forums. Tested on my end using the latest
master
commit, 6fc6bf1 .According to regiscaelus...
It looks like the cycle 16 case is not emulated correctly on division, and the cycle 8 case on multiplication is also not emulated correctly.
Two test ROMs were provided: one by Myself086, and one by Undisbeliever.
The text was updated successfully, but these errors were encountered: