Skip to content

Commit

Permalink
Undo unwarranted change to coding conventions. I am not a fan of the …
Browse files Browse the repository at this point in the history
…aesthetics of private/public at the root but more importantly, we should not be changing coding conventions with almost a decades worth of history at a whim. The conventions are there to have a consistent coding style, that is their primary purpose. When there is so much existing code with the existing style, any change will have to lift an enormous burden of proof as to why its overwhelmingly superior. That is not the case here, so this is being reverted.
  • Loading branch information
dhh committed Mar 13, 2012
1 parent fc3e9b3 commit 4631315
Showing 1 changed file with 1 addition and 0 deletions.
Expand Up @@ -310,6 +310,7 @@ Rails follows a simple set of coding style conventions.
* Two spaces, no tabs.
* No trailing whitespace. Blank lines should not have any space.
* Outdent private/protected from method definitions. Same indentation as the class/module.
* Indent after private/protected.
* Prefer +&&+/+||+ over +and+/+or+.
* Prefer class << self block over self.method for class methods.
* +MyClass.my_method(my_arg)+ not +my_method( my_arg )+ or +my_method my_arg+.
Expand Down

0 comments on commit 4631315

Please sign in to comment.