-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pageId instead of Spacekey and parent title #107
Comments
Hi, thx for interest It's a good technical enhancement ... my opinion is that i would like preserve readability of plugin configuration itself and ... using ID probably it will not However i think that it could be implemented in 2 ways:
I'll add such feature as soon as possible (4.10) What do u think about ? |
Sound great :) I think the new parameter would be the best solution if you like to persist both name of the parameters. So you can define in your documentation: "If you configure the parentPageTitle, you need to specify the spaceKey. If you use the parentPageId, the spaceKey isn't needed anymore". And Because of the "Title" in the name of the parameter parentPageTitle, it can be confusing that the pageId is working there too. |
agree however, in the case of providing |
sry - now I can't follow you :( |
I've deployed release |
what should I need to to to use the snapshot? where is the repository |
the snapshot repo is here to configure in maven <pluginRepositories>
<!-- IF YOU WANT STAY TUNED ON UPDATE REMOVE COMMENT -->
<pluginRepository>
<id>sonatype-repo</id>
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
<releases>
<enabled>false</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</pluginRepository>
</pluginRepositories> |
works - cool :) what is now the order if both is added? |
Hi, Thanks for feedback If both are present pageID has priority (beeing more efficient) I'll arrange official release soon |
I've released the release |
Thank you!
|
Hi
At all let me say Thank you for this maven plugin I just added this plugin to our maven Archetypes to generate our documentation in the future in a better way.
While I tested the plugin there came up the question in my mind "what should I do if the parent page will be renamed" ok editing the pom again.
But wouldn't it be nice to just use the pageId (maybe in a special "usepageid=true" mode.
So we can save us to define the Spacekey and the page title which can contain special characaters.
What do you think about this?
Cheers
Oli
The text was updated successfully, but these errors were encountered: