Skip to content

Commit

Permalink
Make tests approximate and remove type tests
Browse files Browse the repository at this point in the history
  • Loading branch information
bsoyka committed Jan 3, 2021
1 parent b1a965d commit b2647cd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
8 changes: 3 additions & 5 deletions tests/test_average.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from pytest import mark, raises
from pytest import approx, mark, raises

from averager import average

Expand All @@ -8,8 +8,7 @@
[([1, 2], 1.5), ([2, 2, 2, 2, 2], 2), ([1, 2, 3, 4, 5], 3)],
)
def test_average(values, expected):
assert average(values) == expected
assert type(average(values)) == type(expected)
assert average(values) == approx(expected)


def test_average_no_values():
Expand All @@ -19,5 +18,4 @@ def test_average_no_values():

@mark.parametrize("value", [-5, -2.5, -1, 0, 1, 2.5, 5])
def test_average_one_value(value):
assert average([value]) == value
assert type(average([value])) == type(value)
assert average([value]) == approx(value)
10 changes: 5 additions & 5 deletions tests/test_weighted_average.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
from pytest import mark, raises
from random import random

from pytest import approx, mark, raises

from averager import weighted_average


Expand All @@ -11,8 +13,7 @@
],
)
def test_weighted_average(test_input, expected):
assert weighted_average(test_input) == expected
assert type(weighted_average(test_input)) == type(expected)
assert weighted_average(test_input) == approx(expected)


def test_weighted_average_no_values():
Expand All @@ -27,5 +28,4 @@ def test_weighted_average_negative_weights():

@mark.parametrize("value", [1, 53, -4, 6.2, 2.4738])
def test_weighted_average_one_value(value):
assert weighted_average([(value, random() * 100)]) == value
assert type(weighted_average([(value, random() * 100)])) == type(value)
assert weighted_average([(value, random() * 100)]) == approx(value)

0 comments on commit b2647cd

Please sign in to comment.