Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ship Python scripts #42

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

michel-slm
Copy link
Contributor

This complicates distribution packaging in Fedora as the presence of these files led the dependency generator to assume the crate depends on Python

michel in dtparse on ξ‚  dont-ship-python is πŸ“¦ v1.4.0 via 🐍 v3.11.3 via πŸ¦€ v1.69.0 took 6s
⬒ [fedora-toolbox:38] ❯ cargo package --allow-dirty --no-verify
   Packaging dtparse v1.4.0 (/home/michel/src/github/bspeice/dtparse)
    Updating crates.io index
    Packaged 19 files, 175.0KiB (30.7KiB compressed)

michel in dtparse on ξ‚  dont-ship-python is πŸ“¦ v1.4.0 via 🐍 v3.11.3 via πŸ¦€ v1.69.0 took 2s
⬒ [fedora-toolbox:38] ❯ tar tf target/package/dtparse-1.4.0.crate | grep '.py'
dtparse-1.4.0/build_pycompat.py
dtparse-1.4.0/build_pycompat_tokenizer.py
michel in dtparse on ξ‚  dont-ship-python [!] is πŸ“¦ v1.4.0 via 🐍 v3.11.3 via πŸ¦€ v1.69.0 took 9s
⬒ [fedora-toolbox:38] ❯ cargo package --allow-dirty --no-verify
   Packaging dtparse v1.4.0 (/home/michel/src/github/bspeice/dtparse)
    Updating crates.io index
    Packaged 17 files, 157.4KiB (27.4KiB compressed)

michel in dtparse on ξ‚  dont-ship-python [!] is πŸ“¦ v1.4.0 via 🐍 v3.11.3 via πŸ¦€ v1.69.0
⬒ [fedora-toolbox:38] ❯ tar tf target/package/dtparse-1.4.0.crate | grep '\.py'

michel in dtparse on ξ‚  dont-ship-python [!] is πŸ“¦ v1.4.0 via 🐍 v3.11.3 via πŸ¦€ v1.69.0
⬒ [fedora-toolbox:38] ❯

This complicates distribution packaging in Fedora as the presence of these
files led the dependency generator to assume the crate depends on Python

```
michel in dtparse on ξ‚  dont-ship-python is πŸ“¦ v1.4.0 via 🐍 v3.11.3 via πŸ¦€ v1.69.0 took 6s
⬒ [fedora-toolbox:38] ❯ cargo package --allow-dirty --no-verify
   Packaging dtparse v1.4.0 (/home/michel/src/github/bspeice/dtparse)
    Updating crates.io index
    Packaged 19 files, 175.0KiB (30.7KiB compressed)

michel in dtparse on ξ‚  dont-ship-python is πŸ“¦ v1.4.0 via 🐍 v3.11.3 via πŸ¦€ v1.69.0 took 2s
⬒ [fedora-toolbox:38] ❯ tar tf target/package/dtparse-1.4.0.crate | grep '.py'
dtparse-1.4.0/build_pycompat.py
dtparse-1.4.0/build_pycompat_tokenizer.py
```

```
michel in dtparse on ξ‚  dont-ship-python [!] is πŸ“¦ v1.4.0 via 🐍 v3.11.3 via πŸ¦€ v1.69.0 took 9s
⬒ [fedora-toolbox:38] ❯ cargo package --allow-dirty --no-verify
   Packaging dtparse v1.4.0 (/home/michel/src/github/bspeice/dtparse)
    Updating crates.io index
    Packaged 17 files, 157.4KiB (27.4KiB compressed)

michel in dtparse on ξ‚  dont-ship-python [!] is πŸ“¦ v1.4.0 via 🐍 v3.11.3 via πŸ¦€ v1.69.0
⬒ [fedora-toolbox:38] ❯ tar tf target/package/dtparse-1.4.0.crate | grep '\.py'

michel in dtparse on ξ‚  dont-ship-python [!] is πŸ“¦ v1.4.0 via 🐍 v3.11.3 via πŸ¦€ v1.69.0
⬒ [fedora-toolbox:38] ❯
```

Signed-off-by: Michel Alexandre Salim <salimma@fedoraproject.org>
@bspeice
Copy link
Owner

bspeice commented Jun 9, 2023

Definitely unintentional, thanks much. Will get a release cut shortly to publish the change.

@bspeice bspeice merged commit 1f37b60 into bspeice:master Jun 9, 2023
@bspeice
Copy link
Owner

bspeice commented Jun 9, 2023

Release 1.5.0 has shipped to remove Python scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants