Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong parsing of primitive multidimensional array parameters #27

Merged
merged 1 commit into from Nov 18, 2021
Merged

Fix wrong parsing of primitive multidimensional array parameters #27

merged 1 commit into from Nov 18, 2021

Conversation

Netzwerkfehler
Copy link
Contributor

The regex for parsing method parameters has a small bug that causes primitive arrays to always be read as one-dimensional arrays, even if they have more dimensions. In addition, a redundant part was optimised.

Old regex: https://regex101.com/r/c34Rjs/1
New regex: https://regex101.com/r/3fbPGd/1

@bspkrs
Copy link
Owner

bspkrs commented Jul 30, 2021 via email

@bspkrs bspkrs merged commit 197de65 into bspkrs:master Nov 18, 2021
glowredman added a commit to glowredman/MCPMappingViewer that referenced this pull request Jan 8, 2022
Fix wrong parsing of primitive multidimensional array parameters (bspkrs#27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants