Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: autoconf-2.70 fix #58

Merged
merged 1 commit into from Jan 12, 2021
Merged

configure.ac: autoconf-2.70 fix #58

merged 1 commit into from Jan 12, 2021

Conversation

Polynomial-C
Copy link
Contributor

This was previously reported downstream at Gentoo: https://bugs.gentoo.org/750230

autoconf-2.70 changed behavior when using $@ in AC_DEFINE_UNQUOTED which results in the string getting a newline after each element and that later makes the configure run fail. Changing this to $* fixes the issue.

The change to AC_PREREQ is not really required for autoconf-2.70 (especially not settiong it to 2.69 vaule) but I could only test the fix with autoconf-2.69 and autoconf-2.70 and given that v2.69 is nearly eight years old already I don't see a problem in rasing the version requirement here.

Gentoo-bug: https://bugs.gentoo.org/750230
Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
Copy link
Owner

@bstansell bstansell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great...thank you!

@bstansell bstansell merged commit 60bdfc3 into bstansell:master Jan 12, 2021
@Polynomial-C Polynomial-C deleted the autoconf-2.70 branch January 12, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants