-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin function strips whitespace? #3
Comments
Hello, I noticed this problem once or twice but eventually it went away, probably it is some corner case, can you give me the piece of code you are using to pin? |
It actually did it on 500+ pins with no exception. The title-grabbing function is ok, tested multiple times. It's strange it did it only once or twice on your end, as I noticed this on lines 10-18 of RequestBuilder.py:
I changed the replace with a full whitespace. I just run the script on 1000+ pins and it worked without a single error, adding all the necessary spaces to ALL pins. |
Great! Nice catch, I haven't set up collaborators on the repo yet, so I will apply your fix and push the new version :) |
Great, but I was wandering if it would break other things. Why was it
removing that whitespace in the first place?
…On Mon, Sep 2, 2019, 14:26 bstoilov ***@***.***> wrote:
Great! Nice catch, I haven't set up collaborators on the repo yet, so I
will apply your fix and push the new version :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=ADI5VVFP7A2ANQ25M2KNK7LQHUA6TA5CNFSM4ISS6PV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5VVUEQ#issuecomment-527129106>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADI5VVBDKNRTRFIGLGDOPNTQHUA6TANCNFSM4ISS6PVQ>
.
|
I will test it on my end, there was some reason for this for sure. |
Please let me know your findings!
*Flygohr - Gabriele Pezzin*
*Freelance Comic Book Artist and Illustrator*
info@flygohr.com / www.flygohr.com
From Trento, Italy
…On Mon, Sep 2, 2019 at 2:30 PM bstoilov ***@***.***> wrote:
I will test it on my end, there was some reason for this for sure.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=ADI5VVAML7Q6LOZWW5QE3A3QHUBOJA5CNFSM4ISS6PV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5VV6IA#issuecomment-527130400>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADI5VVFTH4AGDOZZM57JTDTQHUBOJANCNFSM4ISS6PVQ>
.
|
It appears that the whole replace was a left over from other issue. I have removed it entirely and all the f unctions are working as expected. The new version 0.2.3 is published let me know if you still have the issue. |
I'll update it and see if it works as soon as I get back to my workstation.
I'll let you know!
…On Tue, Sep 3, 2019, 13:47 bstoilov ***@***.***> wrote:
It appears that the whole replace was a left over from other issue. I have
removed it entirely and all the f unctions are working as expected.
The new version 0.2.3 is published let me know if you still have the issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=ADI5VVFFVJLYLJJXYY4ZL4LQHZFGLA5CNFSM4ISS6PV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5X5V4I#issuecomment-527424241>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADI5VVHXAJQTPEW6UPZ5FEDQHZFGLANCNFSM4ISS6PVQ>
.
|
Yep, it's working out of the box! Just tried the pin function tho, no need for others atm |
Great closing the issue |
Hi there! I am trying to work with your repository from a couple of days but I am having some trouble with the pin titles.
I am using bs4 to get the title of a webpage to use as the pin title. The variable displays correctly when printed, but as soon as I pass it to the pin function all of the white spaces are removed when I look at the board on Pinterest.
Any idea why is this happening? Can you look at my code and help me figure it out?
The text was updated successfully, but these errors were encountered: