Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the compilation problem communicated by CRAN #48

Closed
donotdespair opened this issue Dec 11, 2023 · 0 comments · Fixed by #49
Closed

Fix the compilation problem communicated by CRAN #48

donotdespair opened this issue Dec 11, 2023 · 0 comments · Fixed by #49
Assignees
@donotdespair
Labels
cpp code enhancement requiring the core code improvements
Milestone
v2.1.0

Comments

@donotdespair
Copy link
Member

Problem

CRAN sent a message on the 29th November 2023 requesting updates in the package due to multiple compilation WARNINGs of the sort:

RcppExports.cpp:53:18: warning: format string is not a string literal (potentially insecure) [-Wformat-security]

The issue was with ubuntu-devel distribution and how it compiles Rcpp strings.

More on that on fosstodon, Rcpp-devel, stackoverflow, and GH::Rcpp.

The message from CRAN is available at check_results_bsvars.html.

Solution:

install Rcpp v1.0.11.5>, rerun Rcpp::compileAttributes(), and resubmit a new package version.
@donotdespair donotdespair added the cpp code enhancement requiring the core code improvements label Dec 11, 2023
@donotdespair donotdespair added this to the v2.1.0 milestone Dec 11, 2023
@donotdespair donotdespair self-assigned this Dec 11, 2023
@donotdespair donotdespair linked a pull request Dec 11, 2023 that will close this issue
compiled with the new Rcpp v1.0.11.6 #49
Merged
donotdespair added a commit that referenced this issue Dec 11, 2023
@donotdespair
news for v2.1.0 #48
501eea4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donotdespair donotdespair

Labels
cpp code enhancement requiring the core code improvements
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

compiled with the new Rcpp v1.0.11.6 bsvars/bsvars
1 participant
@donotdespair