Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sampling hyper-parameters #55

Closed
1 task done
donotdespair opened this issue Jan 18, 2024 · 0 comments
Closed
1 task done

Improve sampling hyper-parameters #55

donotdespair opened this issue Jan 18, 2024 · 0 comments
Assignees
@donotdespair
Labels
bug Something isn't working cpp code enhancement requiring the core code improvements
Milestone
v3.0

Comments

@donotdespair
Copy link
Member

donotdespair commented Jan 18, 2024 •
edited
Loading

  • fix the bug with the cpp function sample_hyperparameters where
as_scalar(aux_B * prior_B_V_inv * aux_B.t())

has to be replaced by

as_scalar(aux_B.row(n) * prior_B_V_inv * aux_B.row(n).t())
@donotdespair donotdespair added bug Something isn't working cpp code enhancement requiring the core code improvements labels Jan 18, 2024
@donotdespair donotdespair added this to the v2.2.0 milestone Jan 18, 2024
@donotdespair donotdespair self-assigned this Jan 18, 2024
donotdespair added a commit that referenced this issue Jan 18, 2024
@donotdespair
the latest new for #55
9efba04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donotdespair donotdespair

Labels
bug Something isn't working cpp code enhancement requiring the core code improvements
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
1 participant
@donotdespair