-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change derivation of release unit name: use main module instead of IDL file name #226
Conversation
@huttenlocher Could you please give the comment in service-idl/com.btc.serviceidl/src/com/btc/serviceidl/generator/common/GeneratorUtil.xtend Line 71 in 436956e
|
@kamiddel Could you test this version? (0.6.0-sigiesec-fix-issue-217-SNAPSHOT) |
Yes, I think, this is intended, if API is marked as "main". Don't we have such naming schema in some CAB components as well, e.g. |
436956e
to
7d65f6e
Compare
Yes, there are such paths. But I think that this is for historic reasons only (they were in a single repository before migrating to Git). |
4fce594
to
c733e69
Compare
@huttenlocher I decided to postpone this issue, and created #234 to track it. @huttenlocher Could you review the PR please? There are some possible interactions with the import additions of you and @pekueble, so it should be ready to merge soon. |
Looks as expected |
Added checkModulesOutsideMainAreEmpty and tests
c733e69
to
1d8316d
Compare
com.btc.serviceidl/src/com/btc/serviceidl/validation/IdlValidator.xtend
Outdated
Show resolved
Hide resolved
com.btc.serviceidl/src/com/btc/serviceidl/validation/IdlValidator.xtend
Outdated
Show resolved
Hide resolved
Moved utility function to util.extensions and added tests for getEffectiveMainModule
1d8316d
to
fb3c299
Compare
Define implicit main module if none is specified explicitly
Added some validation rules
Fixes #217