Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change derivation of release unit name: use main module instead of IDL file name #226

Merged
merged 5 commits into from
Oct 19, 2018

Conversation

sigiesec
Copy link
Collaborator

Define implicit main module if none is specified explicitly
Added some validation rules

Fixes #217

@sigiesec sigiesec requested a review from a team October 12, 2018 08:17
@sigiesec
Copy link
Collaborator Author

@huttenlocher Could you please give the comment in

// TODO shouldn't this return two parts instead of a single one containing "."?
a look, in combination with the paths in the tests. I think it looks quite strange that there are paths such as BTC/PRINS/Infrastructure/ServiceHost/Demo/API.NET/Impl rather than BTC/PRINS/Infrastructure/ServiceHost/Demo/API/NET/Impl. Is this intended? If not, I would also change this in the scope of this PR. It was not as visible before, since the tests did not specify a main module, so there was no "NET" part added at all.

@sigiesec
Copy link
Collaborator Author

@kamiddel Could you test this version? (0.6.0-sigiesec-fix-issue-217-SNAPSHOT)

@huttenlocher
Copy link
Collaborator

I think it looks quite strange that there are paths such as BTC/PRINS/Infrastructure/ServiceHost/Demo/API.NET/Impl rather than BTC/PRINS/Infrastructure/ServiceHost/Demo/API/NET/Impl. Is this intended?

Yes, I think, this is intended, if API is marked as "main". Don't we have such naming schema in some CAB components as well, e.g. BTC/CAB/Crypto.NET/Impl etc.

@sigiesec
Copy link
Collaborator Author

Don't we have such naming schema in some CAB components as well, e.g. BTC/CAB/Crypto.NET/Impl etc.

Yes, there are such paths. But I think that this is for historic reasons only (they were in a single repository before migrating to Git).

@sigiesec sigiesec force-pushed the sigiesec-fix-issue-217 branch 2 times, most recently from 4fce594 to c733e69 Compare October 16, 2018 13:45
@sigiesec
Copy link
Collaborator Author

@huttenlocher I decided to postpone this issue, and created #234 to track it.

@huttenlocher Could you review the PR please? There are some possible interactions with the import additions of you and @pekueble, so it should be ready to merge soon.

@kamiddel
Copy link
Collaborator

@kamiddel Could you test this version? (0.6.0-sigiesec-fix-issue-217-SNAPSHOT)

Looks as expected

Added checkModulesOutsideMainAreEmpty and tests
@sigiesec sigiesec merged commit 69f2f31 into master Oct 19, 2018
@sigiesec sigiesec deleted the sigiesec-fix-issue-217 branch October 19, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants