Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new endpoints #110

Merged
merged 5 commits into from
May 2, 2023
Merged

Adding new endpoints #110

merged 5 commits into from
May 2, 2023

Conversation

ndeet
Copy link
Collaborator

@ndeet ndeet commented Apr 18, 2023

  • Store Users
  • Store Email
  • Store Rates
  • Store Rates Config
  • Rate sources (Misc)

@ndeet ndeet marked this pull request as ready for review April 27, 2023 08:35
Copy link
Contributor

@utxo-one utxo-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably eventually clean these up to initialize variables in a class instead of freefloating like these examples. Maybe for v3.

src/Client/Miscellaneous.php Outdated Show resolved Hide resolved
src/Client/StoreRate.php Outdated Show resolved Hide resolved
src/Result/StoreEmailSettings.php Show resolved Hide resolved
src/Result/StoreEmailSettings.php Show resolved Hide resolved
src/Result/StoreRateSettings.php Show resolved Hide resolved
@ndeet
Copy link
Collaborator Author

ndeet commented May 1, 2023

We should probably eventually clean these up to initialize variables in a class instead of freefloating like these examples. Maybe for v3.

The grand plan was/is to move everything to tests and not have examples at all. But I just kept copy and pasting the examples and use it to test if my code works.

For the tests to run on the CI we still have the problem that if the PR is from an contributor and not this same repo the env variables are not available because of GH security restrictions and everything fails. Maybe it is enough to have the tests only locally for now. Or there is a way to trick GH and use repo secrets also for external PRs; wonder how other projects handle this.

@utxo-one
Copy link
Contributor

utxo-one commented May 1, 2023

Maybe if I add my testnet node to github secrets it can just hit my node for my PRs?

@ndeet
Copy link
Collaborator Author

ndeet commented May 2, 2023

Not sure if that works as the gh actions are run on the main repo and not on yours but worth a try 👍

@ndeet ndeet requested a review from utxo-one May 2, 2023 14:54
Copy link
Contributor

@utxo-one utxo-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, i'll be sure to add these endpoints to the v3 version as well.

@ndeet ndeet merged commit 7229287 into btcpayserver:master May 2, 2023
2 of 4 checks passed
@ndeet ndeet deleted the new-endpoints branch May 2, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants