-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new endpoints #110
Adding new endpoints #110
Conversation
ndeet
commented
Apr 18, 2023
•
edited
edited
- Store Users
- Store Email
- Store Rates
- Store Rates Config
- Rate sources (Misc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably eventually clean these up to initialize variables in a class instead of freefloating like these examples. Maybe for v3.
The grand plan was/is to move everything to tests and not have examples at all. But I just kept copy and pasting the examples and use it to test if my code works. For the tests to run on the CI we still have the problem that if the PR is from an contributor and not this same repo the env variables are not available because of GH security restrictions and everything fails. Maybe it is enough to have the tests only locally for now. Or there is a way to trick GH and use repo secrets also for external PRs; wonder how other projects handle this. |
Maybe if I add my testnet node to github secrets it can just hit my node for my PRs? |
Not sure if that works as the gh actions are run on the main repo and not on yours but worth a try 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, i'll be sure to add these endpoints to the v3 version as well.