Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoices default view #1498

Closed
2ge opened this issue Apr 24, 2020 · 7 comments
Closed

Invoices default view #1498

2ge opened this issue Apr 24, 2020 · 7 comments
Labels
Enhancement Improvements to an existing feature Invoice Related to Invoices in BTCPay

Comments

@2ge
Copy link

2ge commented Apr 24, 2020

It would be nice to have setting when one can change default view of list of invoices. For example show all invoices except expired ones (I don't care about those ones).

@NicolasDorier
Copy link
Member

maybe a default filter in user's settings.

@Kukks
Copy link
Member

Kukks commented Apr 24, 2020 via email

@NicolasDorier
Copy link
Member

mmh I think @rockstardev did it actually.

@Eskyee
Copy link
Contributor

Eskyee commented Apr 24, 2020

154D12E3-B081-4E81-8510-85AD7499C04C yes rockstar sorted it

@pavlenex
Copy link
Contributor

I do not remember us ever caching the default filter view. I agree it can be a useful thing.

@pavlenex pavlenex added Enhancement Improvements to an existing feature Invoice Related to Invoices in BTCPay labels Apr 25, 2020
@rockstardev
Copy link
Member

I definitely remember doing this to preserve grid data between navigation to invoice detail. What I think is missing is setting link on top... when you click on Invoices link it can take you to the last Invoices list you were looking.

dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Jun 17, 2020
This addresses and potentially closes btcpayserver#1498. As discussed in the issue this addition maintains the list route params on navigation to the invoice details view. It appends the params to the Invoices item in the top navigation so that one can navigate back to the previous list view.

To be discussed: As the params are not namespaced and I'm grabbing them from the `HttpContext.Request.Query` they are also set on the Payment Requests list view.
Kukks pushed a commit to dennisreimann/btcpayserver that referenced this issue Jun 25, 2020
This addresses and potentially closes btcpayserver#1498. As discussed in the issue this addition maintains the list route params on navigation to the invoice details view. It appends the params to the Invoices item in the top navigation so that one can navigate back to the previous list view.

To be discussed: As the params are not namespaced and I'm grabbing them from the `HttpContext.Request.Query` they are also set on the Payment Requests list view.
rockstardev pushed a commit that referenced this issue Jul 12, 2020
This addresses and potentially closes #1498. As discussed in the issue this addition maintains the list route params on navigation to the invoice details view. It appends the params to the Invoices item in the top navigation so that one can navigate back to the previous list view.

To be discussed: As the params are not namespaced and I'm grabbing them from the `HttpContext.Request.Query` they are also set on the Payment Requests list view.
rockstardev pushed a commit that referenced this issue Jul 12, 2020
This addresses and potentially closes #1498. As discussed in the issue this addition maintains the list route params on navigation to the invoice details view. It appends the params to the Invoices item in the top navigation so that one can navigate back to the previous list view.

To be discussed: As the params are not namespaced and I'm grabbing them from the `HttpContext.Request.Query` they are also set on the Payment Requests list view.
@pavlenex
Copy link
Contributor

pavlenex commented Aug 4, 2020

Should be fixed with #1734 try it out once new release is out and let us know if that's what you wanted, if not we can re-visit this issue. For now I consider it fixed.

@pavlenex pavlenex closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to an existing feature Invoice Related to Invoices in BTCPay
Projects
None yet
6 participants