Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording/UX Fix: Word "Balance" should be "Transaction Amount" on wallet's list transactions page #1887

Closed
maltokyo opened this issue Sep 5, 2020 · 5 comments · Fixed by #1888

Comments

@maltokyo
Copy link

maltokyo commented Sep 5, 2020

Describe the bug
On the wallet transaction list page, one of the columns is called "Balance". It should be called "Transaction Amount"

https://github.com/btcpayserver/btcpayserver/blob/eb0dee07d83db70d3f153fb7a6c2c12212e386ca/BTCPayServer/Views/Wallets/WalletTransactions.cshtml

To Reproduce
Steps to reproduce the behavior:

  1. Go to Wallets in top bar
  2. Click on "Manage" of one wallet
  3. See image below, that column that says Balance is actually the transaction amount.

image

I tried to fix myself, but somehow it said I had to make a branch, but I could only make a fork. Can someone teach me how to "branch" it?

@Zaxounette
Copy link
Member

Zaxounette commented Sep 5, 2020

Hi @maltokyo !

You can follow this doc for your branch issue: https://docs.btcpayserver.org/Contribute/ContributeWrite/WriteSoftware/#step-2

On the string change, it's a nice find, gratz.
IMO you could just leave it at Amount instead of Transaction amount.

Zax.

maltokyo pushed a commit to maltokyo/btcpayserver that referenced this issue Sep 5, 2020
Change Balance Column title to "Transaction Amount" to fix btcpayserver#1887
@maltokyo
Copy link
Author

maltokyo commented Sep 5, 2020

Thanks @Zaxounette ! Done!

@maltokyo
Copy link
Author

maltokyo commented Sep 5, 2020

Closing as #1888 will fix this

@maltokyo maltokyo closed this as completed Sep 5, 2020
@Zaxounette
Copy link
Member

@maltokyo FYI, a tip for your next issue and pull request, when signaling in a PR Closes #ISSUE-NUMBER like you did in #1888 the PR will automatically close that issue, so you don't need to manually close it.

@maltokyo
Copy link
Author

maltokyo commented Sep 5, 2020

Ah, that's cool, TIL. Thanks again for your help and for teaching me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants