Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When collapsed, the sync window blocks the version text in the footer #1941

Closed
pavlenex opened this issue Oct 5, 2020 · 2 comments · Fixed by #1945 or #1946
Closed

When collapsed, the sync window blocks the version text in the footer #1941

pavlenex opened this issue Oct 5, 2020 · 2 comments · Fixed by #1945 or #1946
Labels
good first issue Server Settings UI / UX Front-end issues, for front-end designers

Comments

@pavlenex
Copy link
Contributor

pavlenex commented Oct 5, 2020

Describe the bug
New collapsible sync window is awesome, but we should just make sure it doesn't block the version in the footer.
While you can still the version via various hacks, sometimes a first-time user whoes node is syncing may have a question or a bug report that would require their version to be futher troubleshoot.

To Reproduce
Steps to reproduce the behavior:

  1. Minimize sync window while it's syncing
  2. Scroll to the bottom to check version
  3. It's hard to see the version

Expected behavior
A person should be able to see the version at a bottom even though the node is syncing.

Screenshots
Screenshot 2020-10-05 at 18 41 14

Your BTCPay Environment (please complete the following information):

  • BTCPay Server Version [available in the right bottom corner of footer] Woooot Sir my window is blocking a version 😄 jk it's v1.0.5.6
  • Deployment Method: [e.g. Docker, Manual, Third-Party-hoist] Docker
  • Browser [e.g. chrome, safari] - Chrome, 13" MacAir
@pavlenex pavlenex added UI / UX Front-end issues, for front-end designers good first issue Server Settings labels Oct 5, 2020
@Kukks
Copy link
Member

Kukks commented Oct 6, 2020

oi @dennisreimann my css had a bottom:30px on purpose :P

@dennisreimann
Copy link
Member

Yeah, my bad, will fix this.

dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Oct 6, 2020
@dennisreimann
Fix sync modal styles
f6cf7f5 
Do not overlap the footer. Also removed the underline for the toggle button in chrome. Fixes btcpayserver#1941.
@dennisreimann dennisreimann mentioned this issue Oct 6, 2020
Merged
Kukks added a commit that referenced this issue Oct 6, 2020
@Kukks
Fix modal overlay
7648253 
fixes #1941
@Kukks Kukks mentioned this issue Oct 6, 2020
Merged
Kukks pushed a commit that referenced this issue Oct 6, 2020
@dennisreimann
Fix sync modal styles (#1945)
ace904c 
Do not overlap the footer. Also removed the underline for the toggle button in chrome. Fixes #1941.
Kukks added a commit that referenced this issue Oct 6, 2020
@Kukks
Fix modal overlay (#1946)
cfa568a 
* Fix modal overlay

fixes #1941

* fix speed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Server Settings UI / UX Front-end issues, for front-end designers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sync modal styles dennisreimann/btcpayserver
Fix modal overlay btcpayserver/btcpayserver
3 participants
@dennisreimann @Kukks @pavlenex