Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Manifest malformed on PoS app #4363

Closed
1 task done
NicolasDorier opened this issue Nov 27, 2022 · 0 comments · Fixed by #4373
Closed
1 task done

[Bug]: Manifest malformed on PoS app #4363

NicolasDorier opened this issue Nov 27, 2022 · 0 comments · Fixed by #4373
Assignees
@dennisreimann
Labels
Bug

Comments

@NicolasDorier
Copy link
Member

What is your BTCPay version?

1.7.0

How did you deploy BTCPay Server?

docker deployement

What happened?

My PoS app show a JS error.

image

How did you encounter this bug?

  1. Browse https://donate.nicolas-dorier.com/apps/87kj5yKay8mB4UUZcJhZH5TqDKMD3CznjwLjiu1oYZXe/pos
  2. Hit F12 to show the dev console

Relevant log output

Manifest: Line: 1, column: 102, Syntax error.

What browser do you use?

Brave

Additional information

No response

Are you sure this is a bug report?

  • I confirm this is a bug report
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Nov 28, 2022
@dennisreimann
POS: Fix manifest
946d2b4 
- Manifest v1 doesn't support HEX colors
- Make icon URLs absolute

Closes btcpayserver#4363.
@dennisreimann dennisreimann self-assigned this Nov 28, 2022
@dennisreimann dennisreimann mentioned this issue Nov 28, 2022
Merged
NicolasDorier pushed a commit that referenced this issue Nov 28, 2022
@dennisreimann
POS: Fix manifest (#4373)
84132e7 
- Manifest v1 doesn't support HEX colors
- Make icon URLs absolute

Closes #4363.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dennisreimann dennisreimann

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

POS: Fix manifest dennisreimann/btcpayserver
2 participants
@dennisreimann @NicolasDorier