Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Payment request doesn't have a concept of processing status, goes immediately to settled for on-chain payments #5297

Closed
1 task done
pavlenex opened this issue Sep 7, 2023 · 1 comment · Fixed by #5309
Closed
1 task done

[Bug]: Payment request doesn't have a concept of processing status, goes immediately to settled for on-chain payments #5297

pavlenex opened this issue Sep 7, 2023 · 1 comment · Fixed by #5309
Assignees
@dennisreimann
Labels
Bug good first issue Payment Request Related to Payment Request feature in BTCPay
Milestone
1.11.x

Comments

@pavlenex
Copy link
Contributor

pavlenex commented Sep 7, 2023 •
edited

What is your BTCPay version?

BTCPay Server v1.11.2+1c5fcfe09

How did you deploy BTCPay Server?

Docker

What happened?

When a payment request is paid on-chain, the status doesn't get to processing instead goes to settled.

Two problems:

  1. We don't recognize the processing status in payment request
  2. In payment details, we do use processing but it's designed as settled, should use the same design/style as processing label in invoice view.

How did you encounter this bug?

  1. Create a payment request
  2. Pay on-chain
  3. Check the payment request view

Relevant log output

No response

What browser do you use?

Safari 15.00

Additional information

Screenshot 2023-09-07 at 13 56 23
Screenshot 2023-09-07 at 14 01 08

Are you sure this is a bug report?

  • I confirm this is a bug report
@pavlenex pavlenex added Bug good first issue Payment Request Related to Payment Request feature in BTCPay labels Sep 7, 2023
@pavlenex pavlenex added this to the 1.11.x milestone Sep 7, 2023
@dennisreimann dennisreimann self-assigned this Sep 10, 2023
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Sep 10, 2023
@dennisreimann
Payment Request: Add processing status for on-chain payments
fc0244c 
Closes btcpayserver#5297.
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Sep 10, 2023
@dennisreimann
Payment Request: Add processing status for on-chain payments
a2f1ef2 
Closes btcpayserver#5297.
@dennisreimann dennisreimann mentioned this issue Sep 10, 2023
Merged
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Sep 11, 2023
@dennisreimann
Payment Request: Add processing status for on-chain payments
66d556a 
Closes btcpayserver#5297.
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Sep 12, 2023
@dennisreimann
Payment Request: Add processing status for on-chain payments
e193a72 
Closes btcpayserver#5297.
@Mickledmoore

This comment has been minimized.

Sign in to view
NicolasDorier pushed a commit that referenced this issue Sep 19, 2023
@dennisreimann
Payment Request: Add processing status for on-chain payments (#5309)
17d1832 
Closes #5297.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dennisreimann dennisreimann

Labels
Bug good first issue Payment Request Related to Payment Request feature in BTCPay
Projects
BTCPay Server Roadmap 🛣️
Archived in project
Milestone
1.11.x
Development

Successfully merging a pull request may close this issue.

Payment Request: Add processing status for on-chain payments dennisreimann/btcpayserver
4 participants
@dennisreimann @pavlenex @Mickledmoore and others