Payjoin: Better UIH1 & UIH2 based selection #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kukks
force-pushed
the
payjoin/better-utxo-selection
branch
from
00195df
to
d2b7995
Compare
Kukks
force-pushed
the
payjoin/better-utxo-selection
branch
from
cfcd8b0
to
d359c98
Compare
| psbt.Outputs.Where(o => o.Index != output.Index).Select(o => o.Value).ToArray())) | ||
|
|
||
| foreach (var utxo in (await SelectUTXO(network, utxos, psbt.Inputs.Select(input => input.WitnessUtxo.Value.ToDecimal(MoneyUnit.BTC)), output.Value.ToDecimal(MoneyUnit.BTC), | ||
| psbt.Outputs.Where(psbtOutput => psbtOutput != output).Select(psbtOutput => psbtOutput.Value.ToDecimal(MoneyUnit.BTC)))).selectedUTXO) |
There was a problem hiding this comment.
why do you even change this? psbtOutput => psbtOutput != output
There was a problem hiding this comment.
the params separate the payment output from the others to compute what the modified payment output value will be
There was a problem hiding this comment.
I know but before I was comparing the index, why did you modified to compare the object?
There was a problem hiding this comment.
ah, no clue why. Does it make a difference?
There was a problem hiding this comment.
I don't think so, but I had a doubt that I override the .Equals (which was a bad idea), I prefer not touching what does not break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1470
I need to add some tests.