New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point of Sale Refactoring #1605
Point of Sale Refactoring #1605
Conversation
Falls back to the DefaultView defined in the POS settings. POS: Fix POST-Route
The test failure seems unrelated, can someone retrigger the selenium tests?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy this is finally happening, we can clean up the POs this way.
- I'm not sure if
unspecified
should be an option - We need to leave
EnableShoppingCart
for backwards compat so that existing apps dont lose their default view ( users should not be effected when upgrading to the next version) - We should migrate the data from
EnableShoppingCart
to ViewType, when updating. In the customer-facing action methods, we should just dosettings.DefaultView = settings.EnableShoppingCart? PosViewType.Cart : settings.DefaultView;
- We should make the actions load the view type partials directly (i think but not sure)
Build fail |
@pavlenex you want to manually test? |
tACK. I tested a bit and haven't found any problems. A note though, do we really want a drop down for enabling cart? It's okay but we'd have to alter documentation as well. |
As described in #749 and talked about with @Kukks.
This is mostly UI related as it separates the simple static and cart views.
Replaces the
EnableShoppingCart
setting with aDefaultView
, which can be set toStatic
orCart
.Also gives the ability to define the view type via an optional URL parameter
[Route("/apps/{appId}/pos/{viewType?}")]
, falling back to the default view defined in the settings.These are the things I'd appreciate input on:
EnableShoppingCart
set?Html.GetEnumSelectList<PosViewType>().Where(type => Convert.ToInt32(type.Value) >= 0)
Closes #749.