Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pull Payment view #1764

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

dennisreimann
Copy link
Member

Making sure the different constellations work properly, especially in terms of different breakpoints.

Mobile

mobile-1

mobile-2

mobile-3

Medium

medium-1

medium-2

Large

large-1

large-2

@pavlenex
Copy link
Contributor

I appreciate the influx of PR's but it would be good to focus on stuff we agreed on. For example this will most likely be a wasted effort because of the #1719. Don't have anything against the changes but would be good if we can collaborate a bit better to avoid overlaps and wasted efforts.

@Kukks
Copy link
Member

Kukks commented Jul 23, 2020

Yeah, I think what we should do is merge this one and then consolidate both views to have a common UI framework to reduce code duplication. Easier to be consistent when we use the same "layout"

@dennisreimann
Copy link
Member Author

@pavlenex sorry, I must have overlooked the issue. Did these spontaneously as I came across that page testing stuff. Will take a better look at the list next time.

@pavlenex
Copy link
Contributor

No worries, this is still a good PR, just may get obsoleted quick, don't want your efforts to be in vain.😺
I still think we'll get something good out of it, once merged, we can consolidate the layouts and then proceed with #1719 😉

@NicolasDorier NicolasDorier merged commit 82582d2 into btcpayserver:master Jul 27, 2020
@dennisreimann dennisreimann deleted the pull-payment-ui branch August 2, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants