Allow entry in wallet send via fiat #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kukks Wouldn't this need rounding to the closest sat ? Seems like a lot of numbers after the comma. |
Good call, fixed now |
|
tACK. @Kukks is there a reasonable way to scale this to other currencies and avoid locking it down to the USD in the future? |
pavlenex
approved these changes
Sep 11, 2020
Apparently, it currently works by fetching the currency that's tied to the region of your store's default language lol. We can change this later so that the user can update currency and then have it saved for the next time too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1890
