Invoices list: Remove icon indicator for onchain #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As [discussed on the chat](https://chat.btcpayserver.org/btcpayserver/pl/tcjy5ornhbd8i8jm4yj9y3maie) the icon feels unnecessary and isn't clear to users. Leaving it off and only indicating Lightning transactions avoids confusion.
Zaxounette
approved these changes
Jan 30, 2021
Kukks
approved these changes
Feb 5, 2021
|
@Kukks There's a bit more context and discussion in the linked chat – TL;DR onchain is considered "normal", because that's what most merchants have enabled, whereas LN is regarded as an add-on. In addition to that the onchain icon/emoji wasn't very clear and rather confusing, that's why just omitting it seemed like the best option. |
|
I agree that the icon was confusing, it confused me, I thought it was a clickable link at first... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the chat the icon feels unnecessary and isn't clear to users. Leaving it off and only indicating Lightning transactions avoids confusion.