Ensure "No" selection is maintained for custom price in POS app #2248
Conversation
| @@ -210,7 +213,7 @@ $(function() { | |||
| image = productProperty.replace('image:', '').trim(); | |||
| } | |||
| if (productProperty.indexOf('custom:') !== -1) { | |||
| custom =productProperty.replace('custom:', '').trim(); | |||
| custom = productProperty.replace('custom:', '').trim(); | |||
There was a problem hiding this comment.
Just added a space here.
| @@ -228,7 +231,7 @@ $(function() { | |||
| price: price, | |||
| image: image || null, | |||
| description: description || '', | |||
| custom: Boolean(custom), | |||
There was a problem hiding this comment.
Since custom is always a string (from above custom = productProperty.replace('custom:', '').trim();) casting it to a boolean value using Boolean(custom) will always produce true unless custom happens to be an empty string. Checking for custom === "true" ensures the boolean value is set correctly.
| @@ -263,8 +266,8 @@ $(function() { | |||
| if (inventory) { | |||
| template += ' inventory: ' + inventory + '\n'; | |||
| } | |||
| if (custom) { | |||
| template += ' custom: true\n'; | |||
| if (custom != null) { | |||
There was a problem hiding this comment.
Make sure we don't just always set custom to true in the template.
| @@ -376,6 +379,11 @@ $(function() { | |||
| return item; | |||
| }, | |||
| unEscapeKey : function(k){ | |||
| // Without this check a `false` boolean value will always be returned as an empty string | |||
| if (k === false) { | |||
There was a problem hiding this comment.
This is a special case for when we select "No" and the select value is now false. If we pass false through the below $('<div/>').html(k).text() expression it will return an empty string which doesn't match any of the available <select> options which will make it look as if "No" is not selected. Passing true through $('<div/>').html(k).text(), however, will give you back a string "true" which makes the <select> work correctly.
|
Awesome, thank you! |
|
The test that failed was for coin selection and is unrelated. |
fix #2247
Screen.Recording.2021-02-02.at.8.15.56.PM.mov