Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login: Improve tab navigation for input fields #2258

Merged
merged 2 commits into from Feb 10, 2021

Conversation

dennisreimann
Copy link
Member

Improves the tab indexes so that keyboard navigation goes: Email > Password > Sign in > Create account > Forgot password.

Also autofocuses the email field so that you can start typing right away.

Closes #2257.

Improves the tab indexes so that keyboard navigation goes: Email > Password > Sign in > Create account > Forgot password.

Also autofocuses the email field so that you can start typing right away.

Closes btcpayserver#2257.
@dennisreimann dennisreimann added Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers labels Feb 5, 2021
Copy link
Member

@Kukks Kukks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dennisreimann for the swift PR! 🖤

@dennisreimann
Copy link
Member Author

@MaxHillebrand you're welcome, thanks for the pointer!

@pavlenex pavlenex added this to In progress in 0.12 Milestone via automation Feb 8, 2021
@pavlenex pavlenex moved this from In progress to Reviewer approved in 0.12 Milestone Feb 8, 2021
@NicolasDorier NicolasDorier merged commit 6b18036 into btcpayserver:master Feb 10, 2021
0.12 Milestone automation moved this from Reviewer approved to Done Feb 10, 2021
@dennisreimann dennisreimann deleted the tabindex branch February 15, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants